Group params in angular dependency injection

[jandudulski]

I often see total mess in order how DI params are passed into angular functions. My personal preference is to keep it in such way:

• first params with $ prefix
• then params passed from routing (objects)
• last comes passed services (classes)

So instead of:

angular.module('app').controller 'Something', ($scope, Project, $http, user) ->

it should be:

angular.module('app').controller 'Something', ($scope, $http, user, Project) ->

[venticco]

:+1:

[lukaszwnek]

:+1: I do it exactly that way!

[tallica]

I follow that rule already! :+1:

[jcieslar]

Good :+1: but I prefer:

• first params with $ prefix
• then params passed services (classes)
• last comes passed from routing (objects)

[teamon]

I'd start with most common ones and end with most specific so :+1: for @jcieslar's version

[sheerun]

I'd also make an assignment to make more room for injected dependencies.

App = angular.module('app')

App.controller 'Something', ($scope, Project, $http, user) ->

For more injected dependencies, it is:

App = angular.module('app')

App.controller 'Something', (
  $scope, $compile, Service,
  Project, $http, user, notes
) ->

[sheerun]

And the same as in SLIM: 80 characters hard limit before word wrap

[Ostrzy]

I don't like idea with assignment, but :+1: for @jcieslar version

[hodak]

:+1: for @jcieslar's version - it's easier to distinguish $-services from objects when they are after Capitalized classes

App.controller 'Something', ($scope, $compile, user, Project)

App.controller 'Something', ($scope, $compile, Project, user)