search

monterail / zip-codes

Identify city and state for given zip code
MIT License
109 stars 57 forks source link

Add US Virgin Islands zip codes #36

Open jpalacio-assurance opened 9 months ago

jpalacio-assurance commented 9 months ago

We are examining zip codes like 00803, 00850 as part of our application and noticed these were not included in the data. We did research and it seems including these ZIP codes (US Virgin Islands) would help to complete the dataset.

Resolves: https://github.com/monterail/zip-codes/issues/35

elstgav commented 9 months ago

Based off Wikipedia’s timezone article, it looks like the canonical zone would be "America/Puerto_Rico" instead?

brodyhoskins commented 9 months ago

The Wikipedia link shows that America/Virgin (and that it's linked to America/Puerto_Rico).

I'd argue we should use the more specific time zone for accuracy. It's not farfetched to think that one may change over time and introduce inaccuracies.

NewAlexandria commented 7 months ago

Feel free to also open a PR against https://github.com/suvie-eng/zip-codes/

I'm not wanting to create maintainer controversy - but until the maintainers here integrate all of these, I'd like to have a gem that is the most up to date. Best