search

monteslu / pagenodes

Completely Browser Based IOT Platform
https://pagenodes.com
Apache License 2.0
222 stars 32 forks source link

White Space and Linter #87

Closed samrocksc closed 8 years ago

samrocksc commented 8 years ago

This PR addresses the need for a pull request also a linter of any kind to assist in finding errors in the project moving forward. It addresses issue #86

samrocksc commented 8 years ago

@monteslu this one is almost ready to go, gonna make a few touch ups and tests before i release this one especially on the math nodes

samrocksc commented 8 years ago

@monteslu @louiemontes you can also test this at https://shoutinginfrench.com:3000 if you think there there are any critical errors that might be caused from removal of whitespace.

warbrett commented 8 years ago

Why remove the test folder from the linter?

It's pretty normal to lint against that just because linting helps with things like unused variables, etc.

samrocksc commented 8 years ago

@warbrett The main reason i left the test folder left out was because it required about 4000 lines of whitespace change, and also it is no longer effective, and is going to require a complete reqork.

The node-red method of API access was to use ajax requests, while we are using a modified red.comms core, these 2 are very incompatible at this point in evolution. In the next PR I'm going to be working on i will be removing and hopefully implementing tests again.

samrocksc commented 8 years ago

@monteslu yo, i think i got this one. i tested it for about an hour :P.

monteslu commented 8 years ago

@samrocksc add eslint to dev deps

samrocksc commented 8 years ago

Can Do! Will ping you when finished

samrocksc commented 8 years ago

@monteslu added eslint babel-eslint to save-dev, we should be good. It's also going to automatically use the local eslint.