Closed StaudenmannM closed 4 years ago
Hello
Some remarks:
DompdfWrapper
that is a service on top of Dompdf
dedicated to Symfony. The import in composer is core23/dompdf-bundle
. If you switch to use directly Dompdf
object then I suggest to remove the DompdfWrapper
import and use the dompdf package (dompdf/dompdf
) directly instead of the bundle. (but I prefer using the wrapper/bundle instead of the dompdf direclty, but I don't know why exactly 😄 )Thanks !
Hi, Regarding formats, yes we will have to define another format for printed version (when a user will be able to choose between them :)). Regarding the import, I used dom directly because I didn't know how to change the settings (i.e. A4 landing space) but if there is an option to do it in wrapper I will be happy to use it :)
Hello
I have added a small commit to use the wrapper and set the defaultOrientation to "paysage". The PR is OK for me I let you merge if my commit is OK for you ;)
Fix the PDF format with extra line and put 2 images per page