search

montevideo-tech / hybrid-meetup-platform

Summer Camp WebRTC challenge. This project can be used to host and run hybrid meetups for the video community. Built by video-dev for video-devs 💚
Apache License 2.0
5 stars 2 forks source link

INVESTIGATION: Investigate if is well implemented the screenSharing #150

Open felipeYoungi opened 1 year ago

felipeYoungi commented 1 year ago

Investigate if having the shared screen as a remoteParticipant is: 1: The only way to do it. 2: A good idea. 3: Possible consequences of following this practice vs Alternatives.

This issue will condition the issues #147 and #148 and needs to be done first.

felipeYoungi commented 1 year ago

@marcovidonis we had a discussion about this during planning and we wanted to know your insight. Any thoughts?

yulianag-qualabs commented 1 year ago

Screen sharing is saved as a remoteParticipant along with the audio and video tracks, in order to avoid redoing all the logic that has already been implemented, it seems to me that the best solution is to implement the functionality of pinning a participant on the screen and make it appear larger, and then use this functionality to pin the remoteParticipant who is sharing the screen.

marcovidonis commented 1 year ago

@yulianag-qualabs I tried sharing my screen, but I get Uncaught (in promise) JWTError: duplicate participant: Participant already exists, so I'm not sure treating the screen share as a separate participant is working at the moment. Did you get this to work?

yulianag-qualabs commented 1 year ago

@marcovidonis Perhaps it's because I was already sharing my screen in the same room as you, the screen sharing as a remote participant is working. However, I wonder if there is another way to handle screen sharing, so that it is not treated as a remote participant. Is it possible to listen to some event to display screen sharing as a separate component instead of a stream in the remoteStreams list?