Requests contain offset, not address

[GoogleCodeExporter]

Hi!

This might be a non-issue, but it almost looks
as if the translation from requests to register
numbers is "off by one".

I can't find the translation between request
addresses and register numbers. If a request
for address 0 is received, the library should
validate if the register with number _1_ exists
and return its value - presumed I read the 
specification correctly ;-). Requests for ranges
of addresses should be handled accordingly.

Please check if I am right; otherwise, just
close the issue.

Best regards,

Albert

PS: Is there something like a mailing list for
pyModbus? It would sometimes be better to 
discuss such issues with the developers
before creating a ticket.

Original issue reported on code.google.com by albert.k...@gmail.com on 24 Jan 2011 at 11:33

[GoogleCodeExporter]

Albert, I will take a look today and make sure everything translates correctly. 
As for the mailing list, I hadn't had one in the past, but I just created one: 
http://groups.google.com/group/pymodbus.

Original comment by Bashw...@gmail.com on 24 Jan 2011 at 1:30

• Changed state: Started

[GoogleCodeExporter]

So you are right, the address requested in the PDU does not match the address + 
1 on the data store as defined in section 4.4 of the application protocol 
guide. I can fix this pretty easily by just changing the math in the datastore. 
 I'll try and knock this out later today.

Original comment by Bashw...@gmail.com on 24 Jan 2011 at 3:09

• Changed state: Accepted

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

This issue was closed by revision r94.

Original comment by Bashw...@gmail.com on 25 Jan 2011 at 8:02