montilab / hypeR

An R Package for Geneset Enrichment Workflows
https://montilab.github.io/hypeR-docs/
GNU General Public License v3.0
76 stars 11 forks source link

sizes argument in hyp_dots function #35

Closed kotliary closed 2 years ago

kotliary commented 3 years ago

The documentation for hyp_dots function says that sizes argument is "Size dots by geneset sizes". This is true if merge = FALSE.

But if merge = TRUE the size of dots actually corresponds to the significance value (pval or fdr). It took me a while to find it by looking at the code. Please update the documentation.

Also I don't see a reason not to show the size legends by default (if sizes = TRUE).

anfederico commented 3 years ago

Just updated the docs - thank you. I think you're right, I will update that function soon to allow sizing by geneset sizes when merging multiple signatures.