montoyo / webdisplays

WebDisplays mod for Minecraft 1.12.2
Other
97 stars 52 forks source link

1.16.x support #99

Open XLuma opened 3 years ago

XLuma commented 3 years ago

Hey, I stumbled upon this mod and was kinda hyped by it. Unfort, it seems it only has supports up to 1.12.2. I want to be able to use the mod on the latest version, and planning to (at least try to) update the mod to the latest version. Do you mind if I fork and publish an updated build in the future ? Unless this is already in the work of course.

ghost commented 3 years ago

Hey, I stumbled upon this mod and was kinda hyped by it. Unfort, it seems it only has supports up to 1.12.2. I want to be able to use the mod on the latest version, and planning to (at least try to) update the mod to the latest version. Do you mind if I fork and publish an updated build in the future ? Unless this is already in the work of course.

Let us know if you end up updating it. I'd love to have this mod in 1.16.x

ItsK1tty commented 3 years ago

if the license allows to, fork and make a PR.

montoyo commented 3 years ago

Oh yeah I need to change the license and make it 100% open source. But please go ahead.

XLuma commented 3 years ago

Hey, I stumbled upon this mod and was kinda hyped by it. Unfort, it seems it only has supports up to 1.12.2. I want to be able to use the mod on the latest version, and planning to (at least try to) update the mod to the latest version. Do you mind if I fork and publish an updated build in the future ? Unless this is already in the work of course.

Let us know if you end up updating it. I'd love to have this mod in 1.16.x

No guarantee that I'll do it, because 1.16.4 has drastic changes from 1.12.2 (+ MCEF that may need to be updated to 1.16.4 too) But its on my to-do list

ItsK1tty commented 3 years ago

can you please also plan on #75?

SebAndBlocks commented 3 years ago

Dear Everyone, I soon am Going To Start updating MCEF To 1.16.5 (Hopefully) and Then The Web Displays Mod. Please Note anything you know on MCEF, Web Displays and Chromium Embeded Framework.

ItsK1tty commented 3 years ago

@TurquoiseTNT

114

WebDisplays (which just adds display blocks and doesn't contain a browser engine itself) uses MCEF, which is based on the JCEF (java branch of CEF) which is based on CEF, which is based on Chromium

CEF is an open-source framework that allows developers to embed the Chromium browser engine into their apps and render HTML pages inside these apps, written in C++. It's found by Marshall Greenblatt in 2008 and there are 2 versions of CEF: CEF 1 and CEF 3 CEF 1 is a single-threaded realization of Chromium WebKit API, which is no longer supported and is not being developed. CEF 3 is a multi-threaded realization of Chromium Content API and uses the V8 JavaScript engine Spotify is one of the current developers of the CEF. There are CEF ports to other languages: C, Pascal, Go, Java, Python, Delphi, .NET, etc. MCEF uses CEF 3 and the current Chromium version here is 75, which is 2 year old by now. By default, CEF is not compiled with proprietary codec support but can be enabled while building it. While "default" CEF can play only VP9, VP8, Theora video streams, Opus & Vorbis audio streams, CEF that is built with proprietary codecs can also play AAC, AVC (h.264). I've successfully compiled CEF 89, 88, 87, 86, 85 with proprietary codecs and JCEF that uses my CEF, but have never succeeded to get it running within MCEF, due to montoyo's 2-year-old code that doesn't allow just dropping the new JCEF into the folder and let it run without any edits. MCEF can be tested in-game without WD by pressing F10, which opens a 2D browser window

ItsK1tty commented 3 years ago

Scared?

SmokePuddingEveryday commented 2 years ago

Hoping this mod or something similar gets revisited in the future. Seems like an incredibly challenging project.

SebAndBlocks commented 2 years ago

It's been a bit difficult for me. I'm Saying that it is Beyond my coding limitations. Sorry to Disappoint...