search

montrealrobotics / one4all

An end-to-end fully parametric method for image-goal navigation that leverages self-supervised and manifold learning to replace the topological graph with a geodesic regressor.
MIT License
8 stars 1 forks source link

Deprecated branches in requirements.txt #4

Open Jaeyoung-Lim opened 2 weeks ago

Jaeyoung-Lim commented 2 weeks ago

Problem Description There seems to be some outdated branches in requirements.txt

When running 

pip3 install -r requirements.txt

For example, the line https://github.com/montrealrobotics/one4all/blob/c88735b5b22aca2fd213293569407f76737fd40b/requirements.txt#L5-L6 results in the error message

Collecting submitit
  Cloning https://github.com/facebookincubator/submitit (to revision escape_all) to /tmp/pip-install-fkqwmvx9/submitit
  Running command git clone -q https://github.com/facebookincubator/submitit /tmp/pip-install-fkqwmvx9/submitit
  WARNING: Did not find branch or tag 'escape_all', assuming revision or ref.
  Running command git checkout -q escape_all
  error: pathspec 'escape_all' did not match any file(s) known to git
MikeS96 commented 2 weeks ago

Hi @Jaeyoung-Lim,

Indeed there is a problem with the submitit package. That branch was deleted (potentially merged) into the main branch. That being said, it should not be blocking as this branch was mainly used to run multiple jobs in HPC clusters. I suggest trying to install the plain submitit version, i.e.,

pip install submitit

If you have problem with the stable version, try with the one we used.

pip install submitit==1.4.5

Let us know how it goes!

Jaeyoung-Lim commented 2 weeks ago

@MikeS96 Thanks! That was the only thing that needed to fix for a successful install of dependencies.

I have incorporated this in https://github.com/montrealrobotics/one4all/pull/5