search

montudor / action-zip

A GitHub action used to zip file contents
MIT License
112 stars 32 forks source link

"Zipping a folder from a different work dir" example not using zip from action #33

Open dannystaple opened 1 year ago

dannystaple commented 1 year ago

The "Zipping a folder from a different work dir" example, in the README.md doesn't make use of the zip tool inside the container, and uses the zip tool that may or may not be installed in the job container image. The default github container has a zip tool installed, but use of other containers (for build tools etc) mean that may be missing.

Eg:

    runs-on: ubuntu-latest
    container:
      image: mcr.microsoft.com/dotnet/sdk:7.0-jammy
montudor commented 1 year ago

Good catch! I suppose the temporary solution is to zip from the default working directory. Last time I checked working-directory wasn't supported when directly using an action like this one; I will have to look into this issue.

Thanks for the report!