search

monty68 / uniled

Universal Light Controller Integration for Home Assistant
MIT License
79 stars 11 forks source link

Suggestion for good updates/development #13

Closed rapejim closed 1 year ago

rapejim commented 1 year ago

First of all, THANK YOU SO MUCH for developing this integration. It is amazing!!! I have a SP601E and it works perfect.

I want to write this issue to suggest you if you can do the commits in a new "dev" branch. When you have a few commits and you upgrade the version, you can merge it to the main branch. Now when you commit to the main branch, HA prompts us with an update and it's very stressful, 😜.

image The image above shows how I updated with the previous commits (up to "Fix UI update when fx is cancelled") and now (before I have time to reboot to apply the downloaded changes) I have a new update.... 😅.

monty68 commented 1 year ago

Thanks for the positive feedback and the suggestion, this is my first HA and Python development so it has been a steep learning curve including the development environment, tools, and best practices. I will undoubtedly look to manage the releases better in the future.

dbuezas commented 1 year ago

You can also consider using github releases so you have a place to put the version number and changelog. This way HACS won't notify everybody about commits on the main branch either. Relevant docs: https://hacs.xyz/docs/publish/start/#versions

monty68 commented 1 year ago

You can also consider using github releases so you have a place to put the version number and changelog. This way HACS won't notify everybody about commits on the main branch either. Relevant docs: https://hacs.xyz/docs/publish/start/#versions

I was already doing this, creating releases, but I think only when added as a HACS recognized integration does the versioning work. Anyway, for an FYI, I have created a dev branch and will use going forward but also have a PR into HACS to make this a default integration under HACS. Once I figure out pipy and split the library out, I will attempt to get the integration added to HA as an official integration.