monty68 / uniled

Universal Light Controller Integration for Home Assistant
MIT License
79 stars 11 forks source link

Setting color should cancel effects #9

Closed dbuezas closed 1 year ago

dbuezas commented 1 year ago

If any effect is active, color selection has no effect. I believe this not to be the standard expected behavior, as all my other led lamps automatically disable effects when a color is picked from the color wheel.

Thanks for the component, it works really well and it's so comprehensive! Awesome job!

monty68 commented 1 year ago

Thanks for the feedback it is appreciated, in terms of your issue, which device model are you using?

dbuezas commented 1 year ago

It's an sp611e. I'm playing with it right now and i see that some effects do react to the color wheel (e.g the single color vumeter). I guess this makes my issue irrelevant.

monty68 commented 1 year ago

I can change functionality if a non sound effect is in operation it is cancelled when changing color.

dbuezas commented 1 year ago

That could make sense. Another alternative would be to change the light type to monochromatic in those cases (not sure that's possible)

monty68 commented 1 year ago

OK, quick fix is to cancel and revert to a solid color, can do this in the next few mins. When I get more time I'll look at other options

dbuezas commented 1 year ago

:) thanks! Let me know when to update if you want quick feedback

monty68 commented 1 year ago

v0.2.5 should be ready for testing

dbuezas commented 1 year ago

Seems to work fine! Just two minor details:

monty68 commented 1 year ago

I can fix both of these when I get some more time but will be done this week.

monty68 commented 1 year ago

Fixed in v0.2.6 Beta

dbuezas commented 1 year ago

Feels solid!