search

monzo / envoy-preflight

A wrapper for applications to help with running envoy as a sidecar
MIT License
142 stars 53 forks source link

Create Dockerfile to build app #11

Closed sergiofteixeira closed 4 years ago

jackkleeman commented 4 years ago

Thanks for your contribution! Left one comment, but this looks great!

AceHack commented 4 years ago

any way we could get this for a few more distributions? Like Debian slim?

jackkleeman commented 4 years ago

@AceHack what's your use case? envoy-preflight is just a Go binary, normally I would recommend adding it to your existing Docker images. The above docker file is handy to be able to mount in a bash script - does distro matter much if that's all we're doing? I'm open to contributions, by the way

AceHack commented 4 years ago

If you release the binary that would work on several different platforms that would be great. We are using the docker file to copy the binary into our docker files in a multistage docker file. Download the released binary into out docker would be fine too.

sergiofteixeira commented 4 years ago

updated the dockerfile with an entrypoint, and yes a released binary would be usefull aswell, you could create a github action or smth to automatically release the binary.

jackkleeman commented 4 years ago

@sergioteix @AceHack I've added a release binary https://github.com/monzo/envoy-preflight/releases/tag/v1.0, its generated by a GitHub action on new release. If there's any improvements you'd like, feel free to contribute them.