monzo / response

Monzo's real-time incident response and reporting tool ⚡️
MIT License
1.52k stars 165 forks source link

Limit the closing incident notification to working hours #177

Closed ChrisAnn closed 4 years ago

ChrisAnn commented 4 years ago

The reminder to close an incident will happen exactly 24 hours after the incident was created which could be at a very unsociable hour. This change will ensure the reminder to close an incident only happens between 9am and 6pm.

mattrco commented 4 years ago

Great 👍

I had to refresh my memory of how the notification handler is called - since it's every minute there won't be any missed notifications by excluding these hours.