monzo / response

Monzo's real-time incident response and reporting tool ⚡️
MIT License
1.52k stars 165 forks source link

DRY up signals.py #248

Closed xAzigo closed 1 year ago

xAzigo commented 3 years ago

When working on a fork I needed to add another attribute to incident, which additionally required handling in signals.py, I found this required repeating blocks of code, and having extra knowledge of the codebase to be aware to update signals.py.

I hoped to make an approach that allowed attributes to be added to Incident without this file being modified (unless things need customised).

As this was treated as a learning exercise for me any form of Feedback is appreciated.