search

moo-man / FVTT-DD-Import

Allows Importing Dungeondraft map files into FoundryVTT
MIT License
59 stars 27 forks source link

updated to PackageAuthorData model #126

Closed fmefford closed 1 year ago

fmefford commented 1 year ago

Fixes #122

brockhaus commented 1 year ago

@fmefford You should add "id" to module.json, too, right? I just wanted to update this module for v10 depreciation warnings and saw your FR that is handling this partly already. :)

fmefford commented 1 year ago

Thanks for the heads up! It looks like id is replacing name in the manifest now, so I went ahead and made that change.

brockhaus commented 1 year ago

@fmefford You can have "name" and "id" in the same module.json. That way the file stays compatible with V9 and V10. :) P.S. the same works for author vs authors and dependencies vs relations, too. You can have both versions in one module,json and stay V9 / V10 compatible that way (at least for the module.json)

fmefford commented 1 year ago

Ah makes sense. I went ahead and put the old "author" field back in as well as "id". Let me know if there's any issue. Thanks!

moo-man commented 1 year ago

The module isn't backwards compatible with V9, so I'll be removing the old authors field. The name property is still useful however.