moo-man / WFRP4e-FoundryVTT

The premiere system for running grim and perilous games of Warhammer Fantasy Role-play in the Foundry VTT environment.
Apache License 2.0
87 stars 51 forks source link

WOM Enchanted Staff not applying -1 CN after renaming Active Effect with the Proper Lore name #1546

Closed gibbory closed 1 year ago

gibbory commented 1 year ago

WOM Enchanted Staff not applying -1 CN after renaming Active Effect with the Proper Lore name

Renamed the Enchanted Staff Active effect from Staff of "<>" to "Staff of <>" (Metal) and it fails to apply the -1 CN to Metal spells.

Foundry 10.291, WFRP 6.4.0, WOM 3.0.0

The JSON script to identify the Lore doesn't seem to work: let lore = this.effect.label.split(" ")[2].toLowerCase();

I made a temp fix to use the Standard Robes JSON to identify the lore "type" and Separated the Active Effect Lore name by "()" bracers insead of "<>" bracers for the Enchanted staff and that seemed to work: let lore = this.effect.label.split("(")[1].split(")")[0].toLowerCase();

Foundry: wfrp4e: wfrp4e-core: wfrp4e-starter-set: wfrp4e-rnhd: wfrp4e-eis: wfrp4e-ua1: wfrp4e-dotr: wfrp4e-archives1: wfrp4e-middenheim: wfrp4e-archives1: wfrp4e-pbtt: wfrp4e-altdorf: wfrp4e-ua2: wfrp4e-owb1: wfrp4e-horned-rat: wfrp4e-empire-ruins:

moo-man commented 1 year ago

Staff of "<>" to "Staff of <>" (Metal)

This isn't the proper format. Though I'm not sure if I understand what the actual name you changed it to is. If you follow the instructions in the description, it should work correctly.

If it doesn't, export the item and I can see what's wrong.