moo-man / WFRP4e-FoundryVTT

The premiere system for running grim and perilous games of Warhammer Fantasy Role-play in the Foundry VTT environment.
Apache License 2.0
87 stars 51 forks source link

Generic aspect usage and sheet trigger #2059

Closed Forien closed 3 months ago

Forien commented 3 months ago

This PR allows aspects to be triggered by the system, while letting modules define the implementation.

On the same note, I am unsure if the following schema even belongs to the Generic Aspect Model, since the model itself is abstract and the children should define their own schema (and may not even use this one)

schema.use = new fields.SchemaField({
  formula : new fields.StringField({initial : ""}),
  skill : new fields.StringField({initial : ""})
})
Forien commented 3 months ago

Removed the schema from generic.js in favour of letting children define it

Added support for dynamic partial defined by children, so they don't need to define entire Item Sheet template.