moo-man / WFRP4e-FoundryVTT

The premiere system for running grim and perilous games of Warhammer Fantasy Role-play in the Foundry VTT environment.
Apache License 2.0
87 stars 51 forks source link

[Core Rulebook] Incorrect value of characteristic bonus #2066

Open moo-man opened 3 months ago

moo-man commented 3 months ago

Value of: this.actor.system.characteristics.XXX.bonus is calculated incorrectly. It skips bonus to the inital value of characteristic coming from talents. Example: 34 fellowship +1 advancement + Suave Talent (+5) = 41 fellowship meaning 4 Fel Bonus but this.actor.system.characteristics.fel.bonus=3, as if suave talent wasn't activated. Found this bug trying to activate Sigmar's Fiery Hammer. It incorrectly calculates damage of enhanced weapon when using characteristics increased by some talents.
From: nieironicznie
foundry: 11.315
wfrp4e: 7.1.6
wfrp4e-core: 5.0.4
Active Modules: dd-import, dice-calculator, dice-so-nice, MaterialDeck, materialdeck-wfrp4e, popout, popout-resizer, wfrp4e-character-details