moo-man / WFRP4e-FoundryVTT

The premiere system for running grim and perilous games of Warhammer Fantasy Role-play in the Foundry VTT environment.
Apache License 2.0
87 stars 51 forks source link

[Winds of Magic] Lore-based effects #2076

Open moo-man opened 2 months ago

moo-man commented 2 months ago

The "Set Lore" effect puts the lore name in the name of the main effect of an object (robes, enchanted staff). However, the main effects then compare args.spell.system.lore.value to the name. Therefore, it fails for the "Great Maw" lore. It also fails for translations, if the effects are not adapted.

Adding a spellLore variable such as: let spellLore = game.wfrp4e.config.magicLores[args.spell.system.lore.value].toLowerCase(); and then comparing this to the lore name should solve the problem.
From: p4llando
foundry: 11.315
wfrp4e: 7.2.0
wfrp4e-archives1: 5.0.2
wfrp4e-archives2: 5.0.1
wfrp4e-core: 5.0.5
wfrp4e-owb2: 5.0.2
wfrp4e-rnhd: 5.0.2
wfrp4e-soc: 5.0.0
wfrp4e-starter-set: 5.0.3
wfrp4e-up-in-arms: 5.0.1
wfrp4e-wom: 5.0.3
wfrp4e-zoo: 5.0.1
Active Modules: babele, lib-wrapper, module-credits, socketlib, wfrp4-wfrp4e-npc-generator, wfrp4e-random-treasure, wfrp4e-unofficial-grimoire, wh4-fr-translation