moo-man / WFRP4e-FoundryVTT

The premiere system for running grim and perilous games of Warhammer Fantasy Role-play in the Foundry VTT environment.
Apache License 2.0
86 stars 52 forks source link

[WFRP4e System] [v12] List of all CSS and other visual fixes needed #2094

Open Forien opened 1 month ago

Forien commented 1 month ago

Master List

I created this issue to work as a kind of "Master List" of all required CSS fixes for wfrp4e for v12, so Moo Man can focus on fixing them instead finding them.

I post problems in no particular order, as I find them, trying to group them when possible

Some of them may be too minor to bother, but I posted them anyway.

I tested everything on Chrome.

Sidebar

Sidebar Icons are offset from top

Screenshot ![image](https://github.com/moo-man/WFRP4e-FoundryVTT/assets/11304207/3c375b42-cbd2-4551-8972-55018c68c786)

Button Font Size in Settings tab of Sidebar is small.

Not necessarily bad, but buttons look too empty now. Smaller buttons or bigger font size should look better

Screenshot ![image](https://github.com/moo-man/WFRP4e-FoundryVTT/assets/11304207/9fab7c54-8843-4044-b54b-758da36b9058)

Actor Sheet

Actor Name is huge and doesn't fit properly

Issue is caused by --actor-input-font-size not being defined

Screenshot ![image](https://github.com/moo-man/WFRP4e-FoundryVTT/assets/11304207/58cd53f9-73b0-4a2f-b5cf-7f867e676ac6)

Most of Actor Sheet has smaller font size.

Again, not necessarily bad in some cases, but looks out of place.

Screenshot ![image](https://github.com/moo-man/WFRP4e-FoundryVTT/assets/11304207/c8988d66-ef50-48be-b062-ae96884f2c7a)

Item Browser

All Font Sizes are at least twice too big

Screenshot ![image](https://github.com/moo-man/WFRP4e-FoundryVTT/assets/11304207/595797d1-6a66-4db6-8d86-3b9ffaad0485)

Header doesn't align properly with both buttons (which it does on v11)

Screenshot ![image](https://github.com/moo-man/WFRP4e-FoundryVTT/assets/11304207/7a653d77-5d64-405e-a73a-a71e553f1db5)

Settings Configuration

Font size on buttons is way too big

Screenshot ![image](https://github.com/moo-man/WFRP4e-FoundryVTT/assets/11304207/0c854b85-808e-44db-96fc-fcc620609b68)

Token Configuration

Some checkboxes are way too big

Screenshot ![image](https://github.com/moo-man/WFRP4e-FoundryVTT/assets/11304207/2fcb5a4c-ceca-46e7-8bcb-e2fb48277e1c)

Ring Effects go out of background

Screenshot ![image](https://github.com/moo-man/WFRP4e-FoundryVTT/assets/11304207/c72270c0-3aa5-45b8-973d-55f882a5c0f3)

Light Radius doesn't have full background

Screenshot ![image](https://github.com/moo-man/WFRP4e-FoundryVTT/assets/11304207/251df3b6-3103-411b-8c9f-373b8139e040)

Some inputs look disconnected

Screenshot ![image](https://github.com/moo-man/WFRP4e-FoundryVTT/assets/11304207/63bf8070-60d6-4cb1-9b98-422999221578)

Scene Configuration

Mismatched buttons for Ambience > Environment Lighting

Screenshot ![image](https://github.com/moo-man/WFRP4e-FoundryVTT/assets/11304207/70153956-3095-4863-86d1-07468e6e4d8a)

Documents

Default Trappings now get default Foundry's icon instead of blank

Screenshot ![image](https://github.com/moo-man/WFRP4e-FoundryVTT/assets/11304207/99c276c2-e4a7-4600-b75f-d478d982a122)

Canvas, Tokens and other Placeables

Status Effect for Dead doesn't appear as a "big" effect, instead is displayed as small effect on the side

Screenshot ![image](https://github.com/moo-man/WFRP4e-FoundryVTT/assets/11304207/7b08432e-03e6-4663-9309-e525c789ed26)

Combat Tracker

Wrong automatic Height

When popped out (by right clicking the icon on sidebar), the height is not applied properly on turn change. Moving window fixed the height, but any re-render, like turn change, will make it hide last combatant again

Video: https://i.gyazo.com/c6fd2dbc6c927f4efc518135db01e74e.mp4


Feel free to contribute to this issue by commenting under it, provide screenshots when possible. Make sure the versions you test on are as shown below and that your Font Size setting in Core Foundry is set to default (5)

Foundry: 12.327 wfrp4e: 7.2.1 wfrp4e-core: 5.0.4