search

moo-man / WFRP4e-FoundryVTT

The premiere system for running grim and perilous games of Warhammer Fantasy Role-play in the Foundry VTT environment.
Apache License 2.0
92 stars 54 forks source link

Miscellaneous changes that would make my life easier #2178

Closed silentmark closed 1 day ago

silentmark commented 3 months ago

Most of those changes are rather cosmetic and shouldn't affect system in any way.

  1. change the way how effects are sent via socket to users - always send full effectData instead of sometimes effect data and sometimes uuids.
  2. merge data that is comming from addCondition.
  3. It seems that size modifier didnt work right, there is a proposal to fix it.
  4. extract computeAmbidextrous, this would allow me to playaround with twohanded fight.
  5. minor change of groupadvantage ui update - sometimes i was getting wierd "undefined" exceptions, that were bloating the console for users. Don't know from where it was comming.
  6. sometimes radius calculation was causing problems, this is propsal to check if calculation is needed when radius is just a number.
silentmark commented 1 day ago

@moo-man - went through comments and updated PR.

moo-man commented 1 day ago

I know it doesn't really change anything, but I'm not inclined to make random changes to (that don't really change anything) to fix issues that I haven't seen anyone report 🤷

But, once those are removed this should be good to merge!

silentmark commented 1 day ago

You refer to this change related to combat tab and notifications?

moo-man commented 1 day ago

Right, and the current sizeNum check is intentional and doesn't need to be changed.

silentmark commented 1 day ago

Ok, i will revert those, btw so can you explain to me how this sizeNum works, cause I feel like it's not how it is intended?

silentmark commented 1 day ago

I think all your comments have been resolved.