moo-man / WFRP4e-FoundryVTT

The premiere system for running grim and perilous games of Warhammer Fantasy Role-play in the Foundry VTT environment.
Apache License 2.0
87 stars 52 forks source link

Miscellaneous changes that would make my life easier #2178

Open silentmark opened 1 month ago

silentmark commented 1 month ago

Most of those changes are rather cosmetic and shouldn't affect system in any way.

  1. change the way how effects are sent via socket to users - always send full effectData instead of sometimes effect data and sometimes uuids.
  2. merge data that is comming from addCondition.
  3. It seems that size modifier didnt work right, there is a proposal to fix it.
  4. extract computeAmbidextrous, this would allow me to playaround with twohanded fight.
  5. minor change of groupadvantage ui update - sometimes i was getting wierd "undefined" exceptions, that were bloating the console for users. Don't know from where it was comming.
  6. sometimes radius calculation was causing problems, this is propsal to check if calculation is needed when radius is just a number.