moo-man / WrathAndGlory-FoundryVTT

The official system implementation for Warhammer 40,000 Roleplay: Wrath & Glory by Cubicle 7
GNU General Public License v3.0
13 stars 16 forks source link

Cannot apply re-rolls to hidden GM rolls. #227

Open maddoodles opened 1 year ago

maddoodles commented 1 year ago

Describe the bug I believe this is a known issue, but I figured I'd make a bug report as I've seen there are errors in the console related to it. When you attempt to use a reroll on any kind of hidden roll (Private, Blind or Self), the result will not update. The roll is actually made, as you can actually see it when you use a module like Dice So Nice, but the chat box does not update. I have seen these console messages/errors in relation to this when the roll is made:

commons.js:1703 Error: Roll#evaluate is becoming asynchronous. In the short term, you may pass async=true or async=false to evaluation options to nominate your preferred behavior. ``` Deprecated since Version 8 Backwards-compatible support will be removed in Version 10 at Object.logCompatibilityWarning (commons.js:1692) at Roll.evaluate (foundry.js:9252) at Roll.reroll (foundry.js:9375) at WNGTest.reroll (wrath-and-glory.js:165) at WNGTest.rerollFailed (wrath-and-glory.js:195) at Object.callback (wrath-and-glory.js:5808) at ContextMenu.#onClickItem (foundry.js:56177) at HTMLElement.dispatch (jquery.min.js:2) at HTMLElement.y.handle (jquery.min.js:2) logCompatibilityWarning @ commons.js:1703 evaluate @ foundry.js:9252 reroll @ foundry.js:9375 reroll @ wrath-and-glory.js:165 rerollFailed @ wrath-and-glory.js:195 callback @ wrath-and-glory.js:5808 #onClickItem @ foundry.js:56177 dispatch @ jquery.min.js:2 y.handle @ jquery.min.js:2 ```
commons.js:1947 Uncaught (in promise) Error: undefined. Maximum object expansion depth exceeded ``` [No packages detected] at expandObject (commons.js:1947) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at expandObject (commons.js:1961) at _expand (commons.js:1953) at Array.map () at _expand (commons.js:1952) at Object.expandObject (commons.js:1961) at ClientDatabaseBackend._preUpdateDocumentArray (foundry.js:12700) at ClientDatabaseBackend._updateDocuments (foundry.js:12630) at ClientDatabaseBackend.update (commons.js:6796) at async Function.updateDocuments (commons.js:6153) at async ChatMessage.update (commons.js:6250) expandObject @ commons.js:1947 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 expandObject @ commons.js:1961 _expand @ commons.js:1953 requestAnimationFrame (async) _tick @ ticker.min.mjs:8 requestAnimationFrame (async) _tick @ ticker.min.mjs:8 requestAnimationFrame (async) _tick @ ticker.min.mjs:8 requestAnimationFrame (async) _tick @ ticker.min.mjs:8 requestAnimationFrame (async) _tick @ ticker.min.mjs:8 requestAnimationFrame (async) _tick @ ticker.min.mjs:8 requestAnimationFrame (async) _tick @ ticker.min.mjs:8 requestAnimationFrame (async) _tick @ ticker.min.mjs:8 requestAnimationFrame (async) _tick @ ticker.min.mjs:8 requestAnimationFrame (async) _tick @ ticker.min.mjs:8 requestAnimationFrame (async) _tick @ ticker.min.mjs:8 requestAnimationFrame (async) _tick @ ticker.min.mjs:8 requestAnimationFrame (async) _tick @ ticker.min.mjs:8 requestAnimationFrame (async) _tick @ ticker.min.mjs:8 requestAnimationFrame (async) _tick @ ticker.min.mjs:8 requestAnimationFrame (async) _tick @ ticker.min.mjs:8 requestAnimationFrame (async) _tick @ ticker.min.mjs:8 requestAnimationFrame (async) _tick @ ticker.min.mjs:8 requestAnimationFrame (async) _tick @ ticker.min.mjs:8 requestAnimationFrame (async) _tick @ ticker.min.mjs:8 requestAnimationFrame (async) _tick @ ticker.min.mjs:8 requestAnimationFrame (async) _tick @ ticker.min.mjs:8 requestAnimationFrame (async) _tick @ ticker.min.mjs:8 requestAnimationFrame (async) _tick @ ticker.min.mjs:8 requestAnimationFrame (async) _tick @ ticker.min.mjs:8 requestAnimationFrame (async) _tick @ ticker.min.mjs:8 requestAnimationFrame (async) _tick @ ticker.min.mjs:8 requestAnimationFrame (async) _tick @ ticker.min.mjs:8 requestAnimationFrame (async) _tick @ ticker.min.mjs:8 requestAnimationFrame (async) _tick @ ticker.min.mjs:8 requestAnimationFrame (async) _tick @ ticker.min.mjs:8 requestAnimationFrame (async) _tick @ ticker.min.mjs:8 Show 170 more frames ```

To Reproduce Simply make a hidden roll, and attempt to reroll the result.

Version Numbers Foundry: v10 Build 291 wrath-and-glory: 4.2.1