search

moodle-an-hochschulen / moodle-availability_password

Moodle availability plugin which lets users restrict resources and activities with password access
GNU General Public License v3.0
4 stars 6 forks source link

Fix codechecker complaints about PHPUnit naming #16

Closed abias closed 2 years ago

abias commented 2 years ago

Github actions started to complain recently about the naming of the existing PHPUnit tests:

FILE: ...r/work/moodle-availability_password/moodle-availability_password/moodle/availability/condition/password/tests/privacy_test.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
 36 | WARNING | PHPUnit testcase name "availability_password_privacy_test" does not match file name "privacy_test"
    |         | (moodle.PHPUnit.TestCaseNames.NoMatch)
 36 | WARNING | PHUnit class "availability_password_privacy_test" does not have any namespace. It is recommended to add it to the
    |         | "availability_password" namespace, using more levels if needed, in order to match the code being tested
    |         | (moodle.PHPUnit.TestCaseNames.MissingNS)
------------------------------------------------------------------------------------------------------------------------------------

This originates to a change in local_codechecker which was integrated there in https://github.com/moodlehq/moodle-local_codechecker/pull/161

abias commented 2 years ago

This was solved recently in ed1535e4c55fd8c8ed842fdc385b9748b631f656