moodle-an-hochschulen / moodle-availability_password

Moodle availability plugin which lets users restrict resources and activities with password access
GNU General Public License v3.0
4 stars 6 forks source link

Fix Behat scenario "A student attempts to access the page activity with the activity link, but cancels the popup" #19

Closed abias closed 2 months ago

abias commented 2 years ago

In https://github.com/moodle-an-hochschulen/moodle-availability_password/commit/ca6736e18b26fe59ddca5c8d67603e425ed035aa#diff-053982e787008e7875d9d0dae0b57af4d707e0b769532264f13bbb5eaf38af03R41, the Behat scenario "A student attempts to access the page activity with the activity link, but cancels the popup" had to be commented out as it broke on Moodle 4.0 and the reasons could not be detected.

This issue serves as a reminder to have another look if the reason can be found and the scenario can be fixed.

abias commented 2 months ago

I found the reason now: Clicking "Restricted page" is not precise enough on Moodle 4 as this text is also found in the course index (which does not open the password popup). I have fixed this now in 6486556b969dcc3eee8df7b63b5606f3b504c12b