moodle-an-hochschulen / moodle-availability_role

Moodle availability plugin which lets users restrict resources, activities and sections based on roles
GNU General Public License v3.0
7 stars 13 forks source link

Import of restricted activity doesn't complete cleanly #3

Closed ebithell closed 7 years ago

ebithell commented 8 years ago

I have been testing a variety of scenarios using restrict by role in both Moodle 3.0.4 and Moodle 3.1.2 (with the appropriate versions of the plugin), and have found an issue with importing.

Steps to reproduce:

  1. Restrict an activity/resource to a role (e.g. student)
  2. Go to a different course and attempt to import the restricted activity

The import process halts with an error (screenshot attached below). However when you examine the second course, the activity has in fact been imported and restricted correctly.

Would you be able to take a look at this? Thanks!

import_error

abias commented 8 years ago

Hi ebithell,

thanks for your report.

There was a problem with restoring restrictions before which was fixed in the 3.1 version of the plugin and was not backported to the 3.0 version because of our support policy.

Could you please verify that you have tried version v3.1-r3 of the plugin from https://moodle.org/plugins/pluginversions.php?plugin=availability_role and report back to me that this problem really does still exist in this version?

Thanks, Alex

ebithell commented 8 years ago

Hi Alex

I have been working with v3.1-r3 on Moodle 3.1.2 (I looked first at Moodle 3.0, and then moved on to check the most recent versions). Backup & restore works fine now - it is the import function that is still causing an issue in this version.

It would be great if all features did work in Moodle 3.0, but I fully understand your policy about backporting.

Many thanks for your speedy reply,

Erica

abias commented 7 years ago

Hi Erica,

we have finally found the time to fix this bug in the latest version. Sorry for the delay.

Thanks, Alex

ebithell commented 7 years ago

Hi Alex

Many thanks for your work on this! I'll be installing it shortly in one of our evaluation Moodle instances - it looks to be a real time-saver for teachers when all users with a given role need the same restriction (saves effort maintaining groups).

Thanks,

Erica