aria-expanded should be true/false rather than 1/0

moodle-an-hochschulen / moodle-local_boostnavigation

Moodle plugin which tries to overcome some fixed appearance behaviours of Boost's nav drawer in a clean way

GNU General Public License v3.0

39 stars 27 forks source link

aria-expanded should be true/false rather than 1/0 #111

Closed sharpchi closed 10 months ago

sharpchi commented 2 years ago

I was running the axe accessibility checker on our Moodle page, and it highlighted that aria-expanded 0/1 were invalid values. e.g. https://github.com/moodle-an-hochschulen/moodle-local_boostnavigation/blob/b493b4975692eab9e2c2383bcce3a0efdcf39cea/amd/src/collapsenavdrawernodes.js#L130

The documentation says true/false. https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-expanded

abias commented 10 months ago

This plugin has finally reached end of life now and will not be upgraded to Moodle 4.x.

I would like to invite you to have a look at our Moodle 4 theme theme_boost_union which supports several aspects of this plugin's feature set and is actively maintained and extended. Thank you for your understanding.

Against this background, I will close this issue.