moodle-an-hochschulen / moodle-local_boostnavigation

Moodle plugin which tries to overcome some fixed appearance behaviours of Boost's nav drawer in a clean way
GNU General Public License v3.0
39 stars 28 forks source link

Add support for system roles and site-admin on custom course nodes #17

Closed adpe closed 5 years ago

adpe commented 5 years ago

Hello @abias

I just made a first draft. It does what it should, but would be happy about a code review. There are now two additional parameters to define the global roles and the site admin status.

Best regards Adrian

adpe commented 5 years ago

Hello @abias I want to ask when you plan to review this PR? We're not using it yet in production with these changes. Would be nice if you could check it out.

abias commented 5 years ago

Hi Adrian,

as I wanted to proceed with #14 which should land after this change here, I have finished it myself in https://github.com/moodleuulm/moodle-local_boostnavigation/commit/2844d3d377e2ec2511b33a3b8cfdf2f14cb8ed8c. I have added your name to the Changelog and to the commit message.

Thank you for your contribution!

Cheers, Alex

adpe commented 5 years ago

Many thanks!