Closed adpe closed 5 years ago
Thank you very much, Adrian, for this pull request!
I hope that I will be able to look at it during the next few days.
Cheers, Alex
Hi Adrian,
thank you very much again for this pull request.
Your implemented solution worked at first sight and I was about to merge it.
However, after sleeping over it, I decided that it isn't the way to go because:
$nodevisible = false
) but with the correct language, this node would have become visible. This must not happenSo I ended with with a reimplementation on https://github.com/moodleuulm/moodle-local_boostnavigation/commit/207ffdd5968216282cd4d85930d97985e4b9f779 where I gave you the credits for the idea.
That's why I am closing this PR withing merging it.
Cheers, Alex
Hi @abias
Here's my first solution to add the functionality, to add a node with a
one-liner
for system-context and page-context in parallel.Without this functionality, you must add two separate lines. But then you have the problem, that if you're per example site-admin and the same time teacher in a course you'll see two nodes.
This change should not break existing entries.
Thanks to look at it Adrian