moodle-an-hochschulen / moodle-local_boostnavigation

Moodle plugin which tries to overcome some fixed appearance behaviours of Boost's nav drawer in a clean way
GNU General Public License v3.0
39 stars 27 forks source link

Add handler for change logical connection of optional parameters #22

Closed adpe closed 5 years ago

adpe commented 5 years ago

Hi @abias

Here's my first solution to add the functionality, to add a node with a one-liner for system-context and page-context in parallel.

Without this functionality, you must add two separate lines. But then you have the problem, that if you're per example site-admin and the same time teacher in a course you'll see two nodes.

This change should not break existing entries.

Thanks to look at it Adrian

abias commented 5 years ago

Thank you very much, Adrian, for this pull request!

I hope that I will be able to look at it during the next few days.

Cheers, Alex

abias commented 5 years ago

Hi Adrian,

thank you very much again for this pull request.

Your implemented solution worked at first sight and I was about to merge it.

However, after sleeping over it, I decided that it isn't the way to go because:

So I ended with with a reimplementation on https://github.com/moodleuulm/moodle-local_boostnavigation/commit/207ffdd5968216282cd4d85930d97985e4b9f779 where I gave you the credits for the idea.

That's why I am closing this PR withing merging it.

Cheers, Alex