moodle-an-hochschulen / moodle-local_boostnavigation

Moodle plugin which tries to overcome some fixed appearance behaviours of Boost's nav drawer in a clean way
GNU General Public License v3.0
39 stars 27 forks source link

Topics indented incorrectly #35

Closed t-schroeder closed 5 years ago

t-schroeder commented 5 years ago

When you

  1. have "local_boostnavigation | insertcoursesectionscoursenode" enabled in Site administration,
  2. have a course in topics format and
  3. have course layout set to "Show one section per page" in the course settings

only the first section is indented in the nav drawer. The remaining sections are not indented.

image

P.S.: When you go to another section the indentations don't change. P.P.S.: Collapsing the parent node works, though. It collapses all child nodes, even the ones that are not indented.

abias commented 5 years ago

Hi Tim,

Looking at your screenshot, I am wondering which Moodle version you are on. Since Moodle 3.5, there are icons in front of each navigation node and we have adopted these icons to local_boostnavigation as well.

So, on Moodle 3.6 or 3.7, this should look like this: Course__Demokurs

So, if you are running an older version of Moodle and the plugin, you might have encountered a CSS bug which we didn't spot back then but which also will not be fixes anymore by us (see https://github.com/moodleuulm/moodle-local_boostnavigation#moodle-release-support).

Otherwise, if you are running Moodle 3.6 or 3.7, I am wondering why you don't have the icons in front of the section nodes.

Can you please shed some light on this?

Thanks, Alex

t-schroeder commented 5 years ago

Hi Alex,

I just checked again and found that the problem is in our own theme. We copied the #nav-drawer .list-group-item[data-key="localboostnavigationcoursesections"][data-collapse="0"] + .list-group-item[href$="#section-0"] selector and added padding to it which of course only effects the first section. It didn't have anything to do with the icons.

Sorry for not checking this well enough before I created the issue.

Regards, Tim

abias commented 5 years ago

Hi Tim,

thanks for checking this again. No need to excuse for you, I am simply happy that the problem is not on my side :)

Cheers, Alex