search

moodle-an-hochschulen / moodle-local_boostnavigation

Moodle plugin which tries to overcome some fixed appearance behaviours of Boost's nav drawer in a clean way
GNU General Public License v3.0
39 stars 28 forks source link

Error on call function type(), if "Log in as" in course-context #44

Closed adpe closed 4 years ago

adpe commented 5 years ago

Hello @abias

We've following problem on our platform. If a manager is accessing a user profile within the course https://FQDN/user/view.php?id=XXX&course=XXX to Log in as another user following error is displayed:

image

But in the background you're logged in as the other student. And the error is only displayed, if manager is not assigned in system-context. We've assigned the manager on a course-category context. So the solution is, to assign the role system-wide in the meantime.

I'll have a look to your code and provide a solution if I fixed it.

Greets, Adrian

adpe commented 5 years ago

New important information!

The error will be only displayed like reported above if the course is hidden. When the course is visible all is working like it should. But the error is thrown when the course is hidden and the permissions are set like mentioned above.

abias commented 5 years ago

Hi Adrian,

I thought I understood your problem and tried to examine your problem today, but I have to admit that I was not able to reproduce it locally. It seems to be a rare combination of edge cases.

Could you please give me a full set of steps to reproduce, based on a plain installation of Moodle 3.7?

Otherwise, please give an update if you were already able to examine this problem further and to create a patch.

Thanks, Alex

abias commented 5 years ago

Hi @adpe ,

do you have any additional news for me about this issue?

Thanks, Alex

adpe commented 4 years ago

Hello @abias

I was on holidays and nobody takes it over on our end. I'll have a look to this issue during this day.

Greets, Adrian

abias commented 4 years ago

Thank you, @adpe , for providing an updated pull request. I will have a look at it within or shortly before our 3.8 release.

Thanks, Alex