moodle-an-hochschulen / moodle-local_boostnavigation

Moodle plugin which tries to overcome some fixed appearance behaviours of Boost's nav drawer in a clean way
GNU General Public License v3.0
39 stars 28 forks source link

Font Awsome Icons not appearing - Moodle 3.9.1 #68

Closed ghost closed 3 years ago

ghost commented 4 years ago

Having followed the documentation I've created a link using the exemplar ending in... /course/view.php?id=2||||||fa-graduation-cap

This does not display the expected icon but a generic box. image

This is a superb plug in by the way; hope it becomes core.

abias commented 3 years ago

Hey @demsley ,

on my 3.9 test instance, custom icons work flawlessly.

Could you please double check the syntax of this custom node configuration? I think you got something wrong.

Cheers, Alex

ralie29 commented 3 years ago

Hi! I'm having a similar issue on 2 moodle 3.8.2+ instances: (Build: 20200402 and Build: 20200408) I use the example given in the comments here: https://moodle.org/plugins/local_boostnavigation

Site administration quicklinks|/admin/search.php|en
-List of users|/admin/user.php|||||fa-users
-Manage courses|/course/management.php|||||fa-graduation-cap
-Capability overview|/admin/tool/capability/index.php|||||fa-check-square-o
-Notifications|/admin/index.php|||||fa-wrench

The result: image

It looks the same in all browsers. Do you have any ideas why this isn't working?

abias commented 3 years ago

I am sorry, but this example from the plugin comments seems to be wrong. There is one pipe missing. It should be:

Site administration quicklinks|/admin/search.php|en
-List of users|/admin/user.php||||||fa-users
-Manage courses|/course/management.php||||||fa-graduation-cap
-Capability overview|/admin/tool/capability/index.php||||||fa-check-square-o
-Notifications|/admin/index.php||||||fa-wrench
ralie29 commented 3 years ago

Hey Alexander! Thanks for the quick response! We are one step further with the extra pipe but the icons still can't be properly displayed: image Any additional help would be greatly appreciated :)

abias commented 3 years ago

Hey @ralie29 ,

now that the 3.9 release of this plugin is finally out, I have tested the reported issue again on 3.9 - and I was not able to reproduce it. However, I reopened the issue just to be sure.

Could you please test again, ideally on a fresh installation of Moodle 3.9, with the v3.9-1 release of the plugin? If you can reproduce this issue, please provide steps to reproduce for me.

Thanks, Alex

abias commented 3 years ago

Hey @ralie29 ,

having just published the 3.10 version of the plugin, I am still not able to reproduce this issue on 3.9 and not on 3.10.

With the configuration

Site administration quicklinks|/admin/search.php|en
-List of users|/admin/user.php||||||fa-users
-Manage courses|/course/management.php||||||fa-graduation-cap
-Capability overview|/admin/tool/capability/index.php||||||fa-check-square-o
-Notifications|/admin/index.php||||||fa-wrench

all custom nodes appear fine: grafik

So I think it's time to close this issue again until you come back to me with steps to reproduce.

Cheers, Alex