search

moodle-an-hochschulen / moodle-local_boostnavigation

Moodle plugin which tries to overcome some fixed appearance behaviours of Boost's nav drawer in a clean way
GNU General Public License v3.0
39 stars 28 forks source link

Remove root node "Home" also removes <nav> tag #78

Closed FloMiLe closed 3 years ago

FloMiLe commented 3 years ago

Normally, there are three <nav> tags in the nav bar: for the course, the main one for navigation, and the third for settings.

When one checks the setting Remove root node "Home", apparently the closing of the first and the opening of the second <nav> tag get lost. The result is that the gap above the Dashboard button is removed.

abias commented 3 years ago

I agree that this can happen if you set $CFG->defaulthomepage = Site and then decide to remove the "Home" navigation node. Similar things can happen if you set $CFG->defaulthomepage = Dashboard and then decide to remove the "Dashboard" node.

This is something which can't be prevented and which was already discussed in a similar scenario in #40.

If you want to remove the Home navigation node, then please check if you can set $CFG->defaulthomepage = Dashboard.

Cheers, Alex