search

moodle-an-hochschulen / moodle-local_boostnavigation

Moodle plugin which tries to overcome some fixed appearance behaviours of Boost's nav drawer in a clean way
GNU General Public License v3.0
39 stars 28 forks source link

The user preference to store the sections collapsed status is not working #89

Closed adpe closed 3 years ago

adpe commented 3 years ago

Hi @abias

We've noticed that the described and desired behaviour is not working. The collapsecoursesectionscoursenodesession is stored correctly. But when collapsecoursesectionscoursenodedefault is disabled it will delete the stored user preference which was per example to collapse the sections. For me this is a bug, or do I misunderstood something?

But that's not all. In our case, when the user preference is set it has no effect on the collapsible status of the section. So it doesn't matter if collapsecoursesectionscoursenodesession is a 0 or 1.

Can you reproduce this error?

Greets Adrian

adpe commented 3 years ago

PS: As I've noticed the problem exists only in a Moodle 3.9 environment, but not on a Moodle 3.11 environment.

Update as I saw, the classes are not set, maybe it has some relation to https://tracker.moodle.org/browse/MDL-58964?

Per example this line is triggered https://github.com/moodleuulm/moodle-local_boostnavigation/blob/MOODLE_39_STABLE/lib.php#L532, but the class is never appended to the navigation element.

adpe commented 3 years ago

Found the problem. As we've a child boost theme, we have overrided the flat_navigation.mustache and there is missing the classes variable, which was introduced here https://github.com/abias/moodle/compare/73f8c56dfc...MDL-58964-master#diff-cf8f15fc68e73bf102c37396ae9355703ff8e9262356de9171cc5b58b62aab4dR69.

Thanks anyway and I hope it will help others facing the same issue.

Greets Adrian