search

moodle-an-hochschulen / moodle-local_bulkenrol

Moodle plugin which provides the possibility to bulk enrol a list of users who are identified by their e-mail adresses into a course.
5 stars 17 forks source link

Enroloptions #14

Open sevenseas-gists opened 4 years ago

sevenseas-gists commented 4 years ago

Lets Teachers choose different Fields then email to enrol users by.

tobiasreischmann commented 4 years ago

@abias Are there problems with the travis.yml? It seems that it uses the wrong node version. Could you fix those problems? @rtschu Could you adjust the layout of the bulk enrol displayed to the teacher? In case only one option is selected by the admin, the teacher should not be displayed with a dropdown offering only one option. In this case, it would be nice if the language strings would already use the text of this single field. You could achieve this using variables within the lang strings. There are also some string that still use only the e-mail address. For instance the first sentence:

Here, you can bulk enrol users to your course. A user to be enrolled is identified by his e-mail address stored in his Moodle account.

But also the help text. Teachers will probably get confused if they get only offered a help text for the e-mail option, although they are only able to select for instance the username.

tobiasreischmann commented 4 years ago

Thanks, looks good to me now

abias commented 4 years ago

Thank you for this pull request!

Are there problems with the travis.yml? It seems that it uses the wrong node version. Could you fix those problems?

@tobiasreischmann - Yes. Moodle core updated to a new node version in MDL-66109 and this had to be adopted in .travis.yml. See https://github.com/blackboard-open-source/moodle-plugin-ci/issues/115 for details. I have fixed all of our Github repos now.

@rtschu - Please rebase the PR onto this repo's latest master and Travis should work again. Beyond that, may I ask if your PR is already ready for review or if you are still working on Tobias' feedback?

Cheers, Alex

sevenseas-gists commented 4 years ago

@abias Pull request is ready for review and has been rebased

relecand commented 3 years ago

Hi,

I use this pull request in a productive moodle. Works fine.