abias
commented
2 years ago Hi @melanietreitinger ,
thank you for working so hard on this PR to upgrade this plugin and sorry for my huge latency.
As you may have seen, I have continued to work on this plugin before merging your PR.
I have especially,
- merged PR #17
- merged PR #19
- replaced the deprecated print_error() function with a Moodle exception
- update Moodle Plugin CI configuration to latest recommendation to make MariaDB sticky.
This was done because a) I wanted to see these issues fixed and done in older / supported versions as well and not only in 3.11 b) we sould strive to only do one thing within one PR.
May I ask you to rebase your branch to the latest state of the master branch so that this PR only contains the upgrade to 3.11?
I will then be more than happy to review your PR and finally add you to the group of maintainers of this plugin.
Cheers, Alex
Fix error "Function print_error() has been deprecated; use throw new moodle_exception()" Make mariadb:10.5 sticky / MDL-72131 Integrate pullrequest #17: show default enrol option. Integrate pullrequest #19: Small typo in a language string.