search

moodle-an-hochschulen / moodle-local_bulkenrol

Moodle plugin which provides the possibility to bulk enrol a list of users who are identified by their e-mail adresses into a course.
5 stars 17 forks source link

Distinguish warnings caused by empty line or by invalid content. #25

Closed lucaboesch closed 3 years ago

lucaboesch commented 3 years ago

A lecturer was puzzeled because of a "No e-mail address found in line X (). This line will be ignored." when it was just an empty line causing this. That lead me to the thought of distinguishing the notices.

However, his opinion was preferrable to be silently discarding notices at all when it was about empty lines.

This solution here gives out a warning saying a line was empty. I myself personally think this is preferrable, it could be based by an exporting error of a third system in the generation of the list to import, and then you want to be noticed.

Best, Luca

abias commented 3 years ago

Thank you, Luca, for this contribution and especially for adding a Behat test for this new feature! I will merge this PR now as the failed checks are all caused by issues in your branch which have been fixed here in master in the meantime.