search

moodle-an-hochschulen / moodle-local_bulkenrol

Moodle plugin which provides the possibility to bulk enrol a list of users who are identified by their e-mail adresses into a course.
5 stars 17 forks source link

should privacy class be using polyfill? #4

Closed danmarsden closed 6 years ago

danmarsden commented 6 years ago

It looks like you only have a single branch here in github but your plugins db entry has versions for 3.3/3.4 as well. If you plan to support 3.3 on the master branch you may need to implement the polyfill: https://docs.moodle.org/dev/Privacy_API#Difference_between_Moodle_3.3_and_more_recent_versions

If you don't plan to support 3.3 - feel free to close this as won't fix :-)

abias commented 6 years ago

Hi Dan,

I finally found the time to polish this plugin for plugin repo approval. Thanks for this hint.

We have built this plugin for 3.2 and have uploaded some 3.2 versions to the plugin repo, but they are all invisible now and the version which you will finally approve won't be available for version older than 3.4 according to our Moodle release support strategy (https://github.com/moodleuulm/moodle-local_bulkenrol#moodle-release-support).

Thus, no need to implement the polyfill.

Cheers, Alex