PARAM_RAW used when it looks like PARAM_ALPHANUMEXT should be used?

moodle-an-hochschulen / moodle-local_bulkenrol

Moodle plugin which provides the possibility to bulk enrol a list of users who are identified by their e-mail adresses into a course.

5 stars 17 forks source link

PARAM_RAW used when it looks like PARAM_ALPHANUMEXT should be used? #5

Closed danmarsden closed 6 years ago

danmarsden commented 6 years ago

https://github.com/moodleuulm/moodle-local_bulkenrol/blob/master/index.php#L35

ideally would be good to be more restrictive on that param - it looks like it's supposed to be courseid_timetamp so PARAM_RAW isn't quite right?

abias commented 6 years ago

Hi Dan,

I finally found the time to polish this plugin for plugin repo approval. Thanks for this hint.

I agree that this should be more restrictive. While the use of the key param (which the original developer of the plugin created) is somehow obscure to me, I have changed it to PARAM_ALPHANUMEXT now in 84002a6b3cd7e0bc6eb849e7bb044d1e06593939.

Cheers, Alex