search

moodle-an-hochschulen / moodle-local_profilecohort

Moodle plugin which lets admins manage cohort memberships based on users' custom profile fields
GNU General Public License v3.0
23 stars 19 forks source link

update_all_cohorts_from_rules includes deleted users #21

Closed Lat91 closed 1 year ago

Lat91 commented 5 years ago

The sql in update_all_cohorts_from_rules could include a check that the user is not deleted before adding them to a cohort to avoid adding deleted users to cohorts based on the custom user profile fields.

There is an argument that Moodle should, when a user is deleted, remove those mdl_user_info_data records, however we have seen instances in Moodle databases where this is not the case (i.e. this query returns rows: select * from mdl_user_info_data where userid in (SELECT id FROM mdl_user where deleted=1);)

We recently discovered that this plugin had added deleted users to a cohort which then caused an issue trying to assign a role to members of that cohort.

abias commented 5 years ago

Hi @Lat91 ,

thank you for this report and sorry for the late reply.

We will have a look into this issue and make sure that we find a solution for it.

Thanks, Alex

lhjohn commented 4 years ago

I am still experiencing this issue. For example, for a custom profile checkbox, I create two rules, in order to add everyone on the server to a cohort (I chose to use two rules, because I had the same issue mentioned here: https://moodle.org/mod/forum/discuss.php?d=386022).

First rule is defined as: If _custom_profilefield Is defined the user will be added to the cohort _customcohort. Second rule is defined as: If _custom_profilefield Is not defined the user will be added to the cohort _customcohort.

It may be a bit of a hacky way to include everyone on the server, but I still observe the issue that the plugin adds already deleted users to the cohort.

abias commented 1 year ago

This issue has been finally solved by #27.

Cheers, Alex