search

moodle-an-hochschulen / moodle-local_profilecohort

Moodle plugin which lets admins manage cohort memberships based on users' custom profile fields
GNU General Public License v3.0
23 stars 19 forks source link

Add default profile fields support. #26

Open s3cb0y opened 5 years ago

s3cb0y commented 5 years ago

As many users requested, adding default profile fields support will be a good move.

One problem is that default fields mapped to ids statically in range (1000000, 1000006) and can be problematic if user created more than 1M custom profile fields. This can be increased and also decreased to negative values (signed int), but didn't tested well that way.

abias commented 4 years ago

Thank you, @s3cb0y , for providing this pull request.

However, I see the support for default profile fields more as a burden than as a duty. I also don't remember that "many user", as you wrote, have requested this feature - I remember just one issue / discussion in the past about that.

I would really love to see https://tracker.moodle.org/browse/MDL-28452 solved as this would get finally get rid of the default profile fields and would harmonize all profile fields and would get rid of all legacy default profile fields like ICQ.

I will keep this PR open, but there would have to be some more persuasion from the community to have this merged.

danmarsden commented 2 years ago

FYI - we just looked at this plugin (assuming that it dealt with normal user profile fields) and was surprised it didn't support them - we have a plugin that does something similar to this plugin (local_cohortauto) based on the older auth_mcae which we took over - our plugin is good when we don't already know the cohort names and you want to auto-create the cohorts based on the user data, but your plugin is definitely better when the list of cohorts is already known.

danmarsden commented 2 years ago

one of the really common requests we have is to create cohorts based on the email domain - I'm not sure that will ever be a custom field and will likely always be within the user table.

dmitriim commented 2 years ago

I just hit this plugin and was surprised as @danmarsden that it doesn't support standard user fields like email. Would be very beneficial.

dmitriim commented 2 years ago

An addition to my last comment. We have just released a new plugin https://github.com/catalyst/moodle-tool_cohortmanager that supports standard profile fields and much more.