moodle-an-hochschulen / moodle-local_profilecohort

Moodle plugin which lets admins manage cohort memberships based on users' custom profile fields
GNU General Public License v3.0
23 stars 19 forks source link

Moodle 4.1 - Cohorts managed by local_profilecohort retain gear icon #50

Closed davidpesce closed 11 months ago

davidpesce commented 1 year ago

Just a heads up that with Moodle 4.1.x (and I'm guessing 4.0.x) the gear icon (Site admin > Users > Cohorts) still appears next to cohorts managed by local_profilecohort.

Screenshot 2023-01-26 at 11 06 00 AM

I looked back at a 3.9 site and those icons do not appear.

baumhof commented 1 year ago

is the plugin working with moodle 4.1?

abias commented 1 year ago

Hi @davidpesce ,

many thanks for reporting this issue. I could reproduce this finding and would agree that the managed cohorts should not have this cog icon / action menu.

To be able to understand if this is an issue of this plugin, I tested what happens with the latest release of https://moodle.org/plugins/local_cohortauto from Github. And managed cohorts from this plugin show a cog icon as well. So I think this is a Moodle core regression and not a problem of this plugin.

In Moodle tracker, I did not find a matching tracker issue for this regression. So I created https://tracker.moodle.org/browse/MDL-78071. Unfortunately, I do not have the time to submit a fix there at the moment.

I will keep this issue here open as reference for admins who stumble upon the same issue in this plugin.

Cheers, Alex

abias commented 11 months ago

According to https://tracker.moodle.org/browse/MDL-78071, this glitch has been solved in Moodle core 4.1.5 and 4.2.2 in the meantime. So this issue here can be closed.