moodle-an-hochschulen / moodle-local_profilecohort

Moodle plugin which lets admins manage cohort memberships based on users' custom profile fields
GNU General Public License v3.0
23 stars 19 forks source link

Feature request: skip disabled users #56

Open stdoma opened 1 year ago

stdoma commented 1 year ago

Disabled users are also sorted into global groups if the rules match. It would be nice if you could determine in the plugin or in the individual rules that deactivated users are not assigned.

I implemented a general restriction in the plugin myself. - Thanks for the good setup. This may also be relevant for other people.

abias commented 1 year ago

Hi @stdoma ,

in #27 / #21, a patch was just integrated which stops the plugin from adding deleted users to cohorts. This is not the same as disabled (= suspended) users, but it's definitely something which has been missing up to now.

Having said that, I would disagree that this plugin should not add suspended users to cohorts. Moodle treats suspended users like active users in several places, especially in participants lists within courses.

Against this background, I would vote against this feature request, but I will leave it open for some time for others to comment.

Cheers, Alex

ChrisCYC commented 1 year ago

I'd second to be able to specify whether the plugin includes or excludes disabled users. This could just be via a toggle in the settings. I have an issue at the moment that when users leave the orgnisation, I need to manually enter their record and remove a field so they no longer pull into the cohort. To automate cohort removal based upon whether a Moodle user is 'active' would be great!

jBurson-13 commented 12 months ago

This is an awesome plugin. I think it would be great to have the ability to exclude/remove users from the cohort based on the users active/suspended status.