search

moodle-an-hochschulen / moodle-theme_boost_campus

Moodle 3.x Boost child theme which is intended to meet the needs of university campuses and adds several features and improvements ––– for Moodle 4.x please use our Theme Boost Union
GNU General Public License v3.0
38 stars 25 forks source link

Help Icon content in the modal dialog versions sometimes inherits unwanted CSS layout (example: Help Icons in tables) #106

Closed danowar2k closed 3 years ago

danowar2k commented 3 years ago

We detected something minor with modal help icon dialogs. Those dialogs are placed inside elements near the help icons.

When the help icon is inside a table header, the help icon dialog inherits text layout (e.g. text alignment, font weight, etc.) which can lead to unwanted side effects on the text inside the dialog.

An example for this can be seen at mod/forum/index.php.

danowar2k commented 3 years ago

image

danowar2k commented 3 years ago

Locally we fixed this with a CSS rule for this specific help dialog (we don't know yet where else this could be affecting the layout).

/**
The help icon is inside a table where text is centered and bolder
This fixes both on mod/forum/index.php
 */
#mod_forum-emaildigesttype-modal-dialogue .modal-body {
  text-align: left;
  font-weight: initial;
}

If we knew all the places where this happens we would probably be more unspecific with the rule...

/**
Alternative way for all modal help icon dialog in table headers
 */
th .modal-dialog .modal-body {
  text-align: left;
  font-weight: initial;
}

But maybe the help icon modal dialogs should receive their own Boost Campus CSS class so that rules could be directed at those specific dialogs?

danowar2k commented 3 years ago

PR: https://github.com/moodleuulm/moodle-theme_boost_campus/pull/107

abias commented 3 years ago

This has been solved by #107