search

moodle-an-hochschulen / moodle-theme_boost_campus

Moodle 3.x Boost child theme which is intended to meet the needs of university campuses and adds several features and improvements ––– for Moodle 4.x please use our Theme Boost Union
GNU General Public License v3.0
38 stars 25 forks source link

Possible fix for #106 #107

Closed danowar2k closed 3 years ago

danowar2k commented 3 years ago
danowar2k commented 3 years ago

How can I redo a check? I don't think my pull request is the cause of the failed 7.2 mariadb check...

abias commented 3 years ago

Hi @danowar2k ,

thanks for reporting this issue and for submitting a PR right away.

Your change looks fine to me and I would be happy to merge it. Unfortunately, I have rewritten the master branch in the meantime due to a typo in the CHANGES.md file (I know, rewriting master is bad practice, shame on me).

Additionally, I have fixed a Behat problem on the master branch which was the reason for the failing 7.2 mariadb test in this PR.

May I ask you to rebase your patch onto the latest master branch and push it again?

Thanks, Alex

abias commented 3 years ago

Hey @danowar2k ,

I have just cherry-picked your commit and have merged it into the master branch. Thanks for the contribution!

Cheers, Alex