search

moodle-an-hochschulen / moodle-theme_boost_campus

Moodle 3.x Boost child theme which is intended to meet the needs of university campuses and adds several features and improvements ––– for Moodle 4.x please use our Theme Boost Union
GNU General Public License v3.0
38 stars 25 forks source link

site title with dark navbar uses brand color #16

Closed wimglasseesjibe closed 6 years ago

wimglasseesjibe commented 6 years ago

shouldn't this be white like the rest of the navbar text/icons?

Kathrin84 commented 6 years ago

Hi, thanks for your request. Could you precise this question a bit? On which page does this occur? Do you have a screenshot that shows the problem? Thanks and best, Kathrin

wimglasseesjibe commented 6 years ago

Hi Kathrin,

screenshot is at the bottom.

You'll notice that 'Oud-leerkrachten', the shortname for the site, is in brand color.

Hope this clarifies the issue.

Thanks,

Wim

shortname

Kathrin84 commented 6 years ago

Hi Wim, thanks for your answer. The design of the name is identical to Boost core: A box with the brand color around the site name: bildschirmfoto 2018-02-01 um 12 29 20 This is why I did not changed this as this does also work for the dark navbar. If you already removed the box, you can also change the color and hover color individually in the raw SCSS setting. I hope this helps. Best, Kathrin

wimglasseesjibe commented 6 years ago

Hi Kathrin,

if I'm not mistaking, the 'boxed' version is only applied if you don't have a logo. If you have a logo it shows the shortname in brand text color.

Cheers,

Wim

On Thu, Feb 1, 2018 at 12:32 PM, Kathrin notifications@github.com wrote:

Hi Wim, thanks for your answer. The design of the name is identical to Boost core: A box with the brand color around the site name: [image: bildschirmfoto 2018-02-01 um 12 29 20] https://user-images.githubusercontent.com/4711883/35676348-b7cea916-074b-11e8-9e9c-3ab93cab23d7.png This is why I did not changed this as this does also work for the dark navbar. If you already removed the box, you can also change the color and hover color individually in the raw SCSS setting. I hope this helps. Best, Kathrin

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/moodleuulm/moodle-theme_boost_campus/issues/16#issuecomment-362239084, or mute the thread https://github.com/notifications/unsubscribe-auth/APCrQ69-MfmvVQgKU7ri3cXZASvqxgdJks5tQaC_gaJpZM4RnDOo .

Kathrin84 commented 6 years ago

Hi Wim, thanks for the hint with the uploaded logo. I improved this: https://github.com/moodleuulm/moodle-theme_boost_campus/commit/be29ed79792df7b27a183589b60e525cc901cd33 The latest 3.3 version will be released in the Plugins repository soon. I'll close this issue. Best, Kathrin