search

moodle-an-hochschulen / moodle-theme_boost_campus

Moodle 3.x Boost child theme which is intended to meet the needs of university campuses and adds several features and improvements ––– for Moodle 4.x please use our Theme Boost Union
GNU General Public License v3.0
38 stars 25 forks source link

Text and icons of footer blocks unreadable #21

Closed t-schroeder closed 6 years ago

t-schroeder commented 6 years ago

When placing a block in the footer, its text and icons become white which makes them invisible on the white background of the block.

You can remedy this with custom CSS but it would be nice if the theme would already take care of it.

unbenannt unbenannt2 unbenannt3 unbenannt4

Kathrin84 commented 6 years ago

Hi do-you-even-curl, thanks for the issue. We've already discovered this and fixed it with this commit: https://github.com/moodleuulm/moodle-theme_boost_campus/commit/f042b5e6d161145dad702d82e00336771a5ac03e It is part of the release version 3.4-r2. Do you use this version already? Best, Kathrin

t-schroeder commented 6 years ago

Hi Kathrin, my bad. I was using 3.4-r1 on that Moodle instance. Now that I've upgraded to 3.4-3 it looks like this: unbenannt2 As you can see the icons are still white on a white background. Also the links are underlined which is different from blocks that are not in the footer: unbenannt

Kathrin84 commented 6 years ago

Hi, thanks for the further feedback and the screenshots. I have to admit, that I oversaw the icons totally. So really thanks for the hint. I also ignored the underlined context menu links, because Moodle now underlines links, nevertheless you are completely right on this issue. So, I created another patch: https://github.com/moodleuulm/moodle-theme_boost_campus/commit/8741426e9ee5dc401343b2c75f59539e167a97a7 It will be part of the next version v3.4-r4. ;) I really hope that now everything is fine with the footer and the rest of the styling. :) Best, Kathrin