search

moodle-an-hochschulen / moodle-theme_boost_campus

Moodle 3.x Boost child theme which is intended to meet the needs of university campuses and adds several features and improvements ––– for Moodle 4.x please use our Theme Boost Union
GNU General Public License v3.0
38 stars 25 forks source link

Title position not vertical centered #3

Closed sennewood closed 7 years ago

sennewood commented 7 years ago

It may be occurd only at us, maybe because of our logo, but if not, this is how to fix it:

We had the problem, that the title was not vertical centered within the navbar: mdl_logo_position_pre

We fixed this with:

.navbar-light .navbar-brand.has-logo {
    color: #fff;
    margin-top: -0.2rem;
}

mdl_logo_position_post

Kathrin84 commented 7 years ago

Hi Sebastian, thanks for your hint and solution proposal. Yes, I think this is because of the logo you used. I think I remember that I encountered something similar in my tests. However, we hesitated to implement such a correction, as we were not sure if it would look the same (centered) on all browsers and with different kind of logos and logo resolutions. Could you try if the margin-top: -0,2rem works for different logos? If so, then we would love to improve the code with your proposal. Thanks and cheers, Kathrin

sennewood commented 7 years ago

I've tested the issue with a very high logo. The result looks like before:

mdl_large_logo_test

Kathrin84 commented 7 years ago

Hi Sebastian, I wanted to integrate a solution for this, but then I realised that the cause is settled in Boost core. I would prefer to get it fixed there and not within this theme. I will close this issue and please you to do the adjustment within your own RAW SCSS (as you assumingly already did). Best, Kathrin

Edit: Here's the tracker issue: https://tracker.moodle.org/browse/MDL-60048