search

moodle-an-hochschulen / moodle-theme_boost_campus

Moodle 3.x Boost child theme which is intended to meet the needs of university campuses and adds several features and improvements ––– for Moodle 4.x please use our Theme Boost Union
GNU General Public License v3.0
38 stars 25 forks source link

body and HTML tags are closed before footer is output #43

Closed digitalskill closed 5 years ago

digitalskill commented 6 years ago

The login.mustache template and columns2.mustache template have closing tags then the layouts call and render the additional footer items.

digitalskill commented 6 years ago

Hi Team,

Just following up on the update to see if the changes in the pull request are all good and if anything further is needed.

Cheers,

Kathrin84 commented 6 years ago

Hi @digitalskill,

thank you for your issue and pull request. Unfortunately we did not have time to have a look at this issue, yet. We will try to address it next week or in the nearer future.

Thank you for your patience and we'll come back to you.

Best, Kathrin

digitalskill commented 5 years ago

Just following up - Have you resolved that html is still being output after the closing tags on pages

Kathrin84 commented 5 years ago

Hi @digitalskill,

thank you very much for raising this issue and providing a patch. As the web inspectors do show the structure correctly and this bug was only visible if you had a look at the site source code, we were not aware of this bug.

Finally we found time to address this issue. We decided to go for another solution(https://github.com/moodleuulm/moodle-theme_boost_campus/commit/80a0d3c97762121c7b2e70ca8559fd17c62b592e) than you proposed with your pull request. Nevertheless your pull request is highly appreciated and thank you very much for the work you did with that!

The fix will be included in the next release of Boost Campus.

Best, Kathrin