search

moodle-an-hochschulen / moodle-theme_boost_campus

Moodle 3.x Boost child theme which is intended to meet the needs of university campuses and adds several features and improvements ––– for Moodle 4.x please use our Theme Boost Union
GNU General Public License v3.0
38 stars 25 forks source link

Issue targeted: #43 #44

Closed digitalskill closed 5 years ago

digitalskill commented 6 years ago

Issue name: Body and HTML tags are closed before footer is output

Updated to theme/boost_campus/templates/ (5 files) login.mustache | Copied in from Boost and removed closing HTML tags and JS columns2.mustache | Removed closing HTML tags and JS area closing.mustache | Added the closing tags body, html and add the JS closinglogin.mustache | Added the closing tags body, html and add the JS footer.mustache | Added Missing Div to Footer Area (Minor html fix)

Updated theme/boost_campus/layouts (2 files) columns2.php | Call new closing template at bottom of the page. login.php | Call new closing template at bottom of the page.

Kathrin84 commented 5 years ago

Thank you very much for your pull request, this is highly appreciated! However, I will close this without merging. The reason can be read here: https://github.com/moodleuulm/moodle-theme_boost_campus/issues/43#issuecomment-444465674).